ExternalChangeScanner bug fixes and improvement #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remember this option for ExternalChangeScanner Bug fixes: Exception for not executing on awt thread Handling closing window without selecting an option
neph1
commented
Dec 27, 2022
| @@ -173,12 +208,16 @@ private void applyExternalData(final boolean onlyMeshData, | |||
| new CopyMaterialDataFromOriginal(finder).update(spat, original); | |||
| } | |||
| // Do a complicated recurse refresh since AbstractSceneExplorerNode:refresh() isn't working | |||
| SceneApplication.getApplication().enqueue((Runnable) () -> { | |||
| SwingUtilities.invokeLater(() -> { | |||
There was a problem hiding this comment.
This solves an exception I don't remember seeing before
neph1
commented
Dec 27, 2022
| LOGGER.log(Level.INFO, "Saving selection " | ||
| + "{0}", savedOption); | ||
| } | ||
| if (message.getValue().equals(cancel) || message.getValue().equals(noOption)) { |
There was a problem hiding this comment.
Previously didn't handle pressing the "x" to close the window.
|
Let me know if anyone wants to test this, or I'll merge it "soon" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature:
Remember this option for ExternalChangeScanner. Fixes #343
Bug fixes:
Exception for not executing on awt thread
Handling closing window without selecting an option