Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OgreXML #264

Closed
MeFisto94 opened this issue Apr 5, 2020 · 3 comments
Closed

Remove OgreXML #264

MeFisto94 opened this issue Apr 5, 2020 · 3 comments
Labels
Milestone

Comments

@MeFisto94
Copy link
Member

Maybe as an intermediate solution add a warning dialogue to recommend gltf.

@MeFisto94 MeFisto94 added this to the 3.3 Release milestone May 29, 2020
neph1 added a commit to neph1/sdk that referenced this issue Mar 19, 2022
@tonihele tonihele modified the milestones: 3.3 Release, 3.5 release Sep 16, 2022
@tonihele
Copy link
Contributor

tonihele commented Sep 16, 2022

Also does this issue justify removing the million years old bundled Blender from the SDK? I don't see why it would be needed anymore. Was it that the particular version we use just happens to for with the OgleXML stuff? Now that it will be gone. We could remove Blender altogether?

The old version probably can't do GLTF. And I don't see much point in getting a newer version to bloat the SDK side. People would be free to choose their modeling software, and version. Am I right @MeFisto94 ? If so.. I'll create a new issue of this.

@MeFisto94
Copy link
Member Author

The reason that we did bundle blender is twofold:
Yes, it is because that used to be some very specific version that was the only compatible with the ogre xml script I think, but we bumped that to 2.79, the last version that the .blend importer supported.

We also use it to invoke scripts on it to be able to import fbx without relying on the engines FBX importer (and maybe other formats such as .dae), which is exactly the same way unity does it, minus the fact that they search Unity on PATH and export to fbx and import fbx manually. We'd need to change that to support more recent blenders and import .dae, .fbx, .stl and what not into blender -> auto convert to gltf and import the gltf into j3o.

The only concern I have that way, is that we loose the ability to support non-standard-pbr-shading materials, because that's the only thing gltf can really express without extensions. But I guess if you're not willing to work in an age old blender version as an artist, that's the only way you got anyway.

neph1 added a commit that referenced this issue Oct 7, 2022
#264 Removal of ogrexml. Unsure of whether I've caught everything, bu…
neph1 added a commit to neph1/sdk that referenced this issue Oct 7, 2022
…caught everything, but it builds and loads."

This reverts commit 0731b0a.
@neph1
Copy link
Contributor

neph1 commented Oct 22, 2022

Assuming this complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants