Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise Error System #17

Closed
j-mie6 opened this issue Nov 12, 2023 · 0 comments · Fixed by #25
Closed

Optimise Error System #17

j-mie6 opened this issue Nov 12, 2023 · 0 comments · Fixed by #25
Assignees
@j-mie6
Labels
bug Something isn't working

Comments

@j-mie6
Copy link
Owner

j-mie6 commented Nov 12, 2023

The error system is in place (with a couple of bits of missing functionality or bugs). However, the remaining stuff is much easier to do when the system is optimised with defunctionalised optimisations applied. This will allow us to keep the relevant information around for longer.

This should be a priority so that amend's unexpected token can be fixed, and the token widening can be done.
@j-mie6 j-mie6 added the bug Something isn't working label Nov 12, 2023
@j-mie6 j-mie6 self-assigned this Nov 12, 2023
@j-mie6 j-mie6 mentioned this issue Nov 12, 2023
Closed
@j-mie6 j-mie6 mentioned this issue Jan 26, 2024
Merged
j-mie6 added a commit that referenced this issue Jan 29, 2024
@j-mie6
Optimise Error System (#25)
b0a5bd4 
Fixes #17, by introducing `DefuncError` abstraction, allowing for proper
implementation of `amend` as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-mie6 j-mie6

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimise Error System j-mie6/gigaparsec
1 participant
@j-mie6