Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types.go #2

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Update types.go #2

merged 2 commits into from
Jan 23, 2024

Conversation

laredoer
Copy link
Contributor

@laredoer laredoer commented Jan 22, 2024 •
edited
Loading

TransactionInfo struct add Currency and Price field

The latest documentation already has these two fields

App Store Server Notifications

Update types.go
198740c 
TransactionInfo struct add Currency and Price field
@izniburak
Copy link
Owner

Hi @laredoer ,
Thanks for your contribution. I'll check the changes and fix the pipeline, after that merge it!

@izniburak
Copy link
Owner

Also, I think we can add omitempty flag for the new fields of the struct, because we need to cover both App Store APIs, old and new. Old version doesn't have Price and Currency  fields.

Update types.go
3d262d0 
add `omitempty` flag
@laredoer
Copy link
Contributor Author

Also, I think we can add omitempty flag for the new fields of the struct, because we need to cover both App Store APIs, old and new. Old version doesn't have Price and Currency  fields.

It's been added.

@izniburak izniburak merged commit b8e9c86 into izniburak:main Jan 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laredoer @izniburak