Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid_sample #22128

Closed
wants to merge 35 commits into from
Closed

grid_sample #22128

wants to merge 35 commits into from

Conversation

JONAHKYAGABA
Copy link

@JONAHKYAGABA JONAHKYAGABA commented Aug 18, 2023

Close #21957
START ADDING GRID SAMPLE TO PADDLE FRONTEND

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist labels Aug 18, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@iamjameskeane
Copy link
Contributor

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@JONAHKYAGABA Can you please reference the issue that you are tackling in this PR, Thanks!

@JONAHKYAGABA JONAHKYAGABA changed the title grid_sample #21957 grid_sample Close #21957 Aug 20, 2023
@JONAHKYAGABA JONAHKYAGABA changed the title grid_sample Close #21957 grid_sample Aug 20, 2023
@JONAHKYAGABA
Copy link
Author

Close #21957

@JONAHKYAGABA
Copy link
Author

Hi @jkeane508 sorry i had forgotten to link it but its sorted and am still updating the function.

@@ -83,6 +83,15 @@ def test_jax_add(
x=x[0],
y=x[1],
)
@handle_frontend_test(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I don't think your test implementation is quite right. Please refer to the docs or take some inspiration from other tests in this file.

Copy link
Author

@JONAHKYAGABA JONAHKYAGABA Aug 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jkeane508 i kindly request for a review,
And also am facing an error while running the tests.Am using a minconda environment.
" backend_version = {"version": paddle.version.full_version}
E AttributeError: module 'paddle' has no attribute 'version'"

https://discord.com/channels/799879767196958751/933380219832762430/1145083248121217165

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API labels Aug 21, 2023
@iamjameskeane iamjameskeane removed their assignment Aug 22, 2023
# Conflicts:
#	ivy/functional/frontends/paddle/nn/functional/vision.py
@JONAHKYAGABA JONAHKYAGABA reopened this Aug 26, 2023
@JONAHKYAGABA
Copy link
Author

Hello @jkeane508 please kindly review this PR or inform me n how to proceed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid_sample
6 participants