Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paddle frontend unfold #21590

Closed
wants to merge 0 commits into from
Closed

paddle frontend unfold #21590

wants to merge 0 commits into from

Conversation

Deepdive543443
Copy link
Contributor

Close #21565

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 10, 2023
@ivy-seed ivy-seed assigned Dsantra92 and AnnaTz and unassigned Dsantra92 Aug 10, 2023
AnnaTz
AnnaTz suggested changes Aug 15, 2023
View reviewed changes
ivy_tests/test_ivy/test_frontends/test_paddle/test_nn/test_functional/test_common.py Outdated
channels = draw(helpers.ints(min_value=1, max_value=3))

x = draw(
helpers.array_values(dtype=dtype[0], shape=[1, channels, h_size, w_size], min_value=0, max_value=1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be generating a random number of batches instead of hardcoding it to 1. Otherwise we are not fully testing the function.

ivy_tests/test_ivy/test_frontends/test_paddle/test_nn/test_functional/test_common.py Outdated

x = draw(
helpers.array_values(dtype=dtype[0], shape=[1, channels, h_size, w_size], min_value=0, max_value=1)
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please resolve the lint errors detected by our CI checks shown at the bottom of the PR page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaTz AnnaTz AnnaTz requested changes

Assignees

@AnnaTz AnnaTz

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unfold
4 participants
@Deepdive543443 @AnnaTz @Dsantra92 @ivy-leaves