Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paddle max_pool2d #19140

Closed
wants to merge 13 commits into from
Closed

Paddle max_pool2d #19140

wants to merge 13 commits into from

Conversation

Sar-thak-3
Copy link

@Sar-thak-3 Sar-thak-3 commented Jul 10, 2023

Close #19063

@ivy-leaves ivy-leaves added Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist Ivy Functional API Ivy API Experimental Run CI for testing API experimental/New feature or request labels Jul 10, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sar-thak-3
Thanks for the PR🙂
I haven't gone much through your code but there first changes needed😂
You can remove these new added files and add the changes to respective submodules

@Sar-thak-3
Copy link
Author

Hi @hirwa-nshuti , thank you for replying, should I remove the changes I made in backend submodules?

@Sar-thak-3
Copy link
Author

Sar-thak-3 commented Jul 11, 2023

@hirwa-nshuti I am new to Ivy, and it would be really helpful if you can guide me through this process.

Now in this pr, I only left those changes in the paddle/backend which are extremely necessary for max_pool2d for its functioning.

Kindly review the PR and let me know all the changes required.

@Sar-thak-3
Copy link
Author

Hi @hirwa-nshuti , all the test cases are working fine locally, kindly review the pr and let me know the changes required.

Thanks for your cooperation!

Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sar-thak-3

Would you resolve the merge conflicts here for me to be able to run the tests locally

@fnhirwa fnhirwa assigned fnhirwa and unassigned RickSanchezStoic Aug 9, 2023
@ivy-seed ivy-seed added the Stale label Aug 19, 2023
@NripeshN NripeshN closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_pool2d
6 participants