-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paddle max_pool2d #19140
Paddle max_pool2d #19140
Conversation
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sar-thak-3
Thanks for the PR🙂
I haven't gone much through your code but there first changes needed😂
You can remove these new added files and add the changes to respective submodules
Hi @hirwa-nshuti , thank you for replying, should I remove the changes I made in backend submodules? |
@hirwa-nshuti I am new to Ivy, and it would be really helpful if you can guide me through this process. Now in this pr, I only left those changes in the paddle/backend which are extremely necessary for max_pool2d for its functioning. Kindly review the PR and let me know all the changes required. |
Hi @hirwa-nshuti , all the test cases are working fine locally, kindly review the pr and let me know the changes required. Thanks for your cooperation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sar-thak-3
Would you resolve the merge conflicts here for me to be able to run the tests locally
Close #19063