Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document safety about socket count for embassy #18

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

AnthonyGrondin
Copy link
Contributor

I ran into an edge case where I didn't supply enough sockets to use the server for edge-http with embassy-net and esp-wifi, and smoltcp would panic with adding a socket to a full SocketSet.

This document the behavior so that users are aware to provide enough sockets, taking into account the sockets used for DHCP, DNS, etc. when initializing their StackResources<N>

Copy link
Owner

@ivmarkov ivmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for reacting so late small comment left.

edge-nal-embassy/src/tcp.rs Outdated Show resolved Hide resolved
@ivmarkov
Copy link
Owner

ivmarkov commented Jul 9, 2024

Thanks!

@ivmarkov ivmarkov merged commit 640a4f2 into ivmarkov:master Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants