Initial appimageupdatetool support

[Samueru-sama]

I think we better first manually add this to the popular big applications and see how it turns out before adding it to all the scripts.

[ivan-hc]

[ ... ] before adding it to all the scripts.

the above is my avidemux, not the official one

[Samueru-sama]

Im about to go to sleep, but remember that the script should continue if appimageupdate fails.

[ivan-hc]

[ ... ] but remember that the script should continue if appimageupdate fails.

consider also that sandboxed apps are not executable, being managed by Aisap, and that if appimageupdatetool works, there are some .old files that need to be removed

Im about to go to sleep [ ... ]

take care

[Samueru-sama]

[ ... ] but remember that the script should continue if appimageupdate fails.

consider also that sandboxed apps are not executable, being managed by Aisap, and that if appimageupdatetool works, there are some .old files that need to be removed

There should be no .old files since appimageupdate is using the -Or flag which deletes the old file.

EDIT: I tested the script already with brave and had no issues.

[ivan-hc]

anyway, if to add that line is all is needed and other commands and variables are unused in the AM-updater script... its enough to add the function to APP-manager directly, and instead to made it call the AM-updater, it can manage updates directly.

Just two are the functions that take care of running the AM-updater scripts, and are quite simple

function _update_app() {
	if [ -w "$APPSPATH"/"$arg"/AM-updater ]; then
		start=$(date +%s) &&
		sh -x "$APPSPATH"/"$arg"/AM-updater >/dev/null 2>&1 | echo -ne ' Updating "'"$APPNAME"'"...\r' &&
		end=$(date +%s) &&
		echo " ◆ $APPNAME is updated, $((end - start)) seconds elapsed!" &
	else
		echo " ✖ $APPNAME is read-only, cannot update it!"
	fi
}

function _update_all_apps() {
	for f in "$APPSPATH"/*/; do
		cd "$f" 2>/dev/null || exit 1
		arg=$(printf '%s\n' "${PWD##*/}")
		if test -f "$APPSPATH"/"$arg"/AM-updater; then
			APPNAME=$(echo "$arg" | tr '[:lower:]' '[:upper:]')
			_update_app
		fi
	done
	wait
	echo "$DIVIDING_LINE"
	_update_determine_apps_version_changes
	rm -Rf "$APPSPATH/*/tmp"
}

[ivan-hc]

you can start test the two functions above instead, without having to update all the scripts

[ivan-hc]

Just two are the functions that take care of running the AM-updater scripts, and are quite simple

sorry, it is even more simple: one function you should check

function _update_app() {
	if [ -w "$APPSPATH"/"$arg"/AM-updater ]; then
		start=$(date +%s) &&
		sh -x "$APPSPATH"/"$arg"/AM-updater >/dev/null 2>&1 | echo -ne ' Updating "'"$APPNAME"'"...\r' &&
		end=$(date +%s) &&
		echo " ◆ $APPNAME is updated, $((end - start)) seconds elapsed!" &
	else
		echo " ✖ $APPNAME is read-only, cannot update it!"
	fi
}

[ivan-hc]

The below function is just a "draft" and doesn't mean nothing, take it as a proof of concept

function _update_app() {
	if [ -w "$APPSPATH"/"$arg"/AM-updater ]; then
		if command -v appimageupdatetool >/dev/null 2>&1; then
			start=$(date +%s) &&
			appimageupdatetool -Or "$APPSPATH"/"$arg"/AM-updater && chmod a+x "$APPSPATH"/"$arg"/AM-updater && echo "$version" > "$APPSPATH"/"$arg"/version &&
			end=$(date +%s) &&
			echo " ◆ $APPNAME is updated, $((end - start)) seconds elapsed!" &
		else
			start=$(date +%s) &&
			sh -x "$APPSPATH"/"$arg"/AM-updater >/dev/null 2>&1 | echo -ne ' Updating "'"$APPNAME"'"...\r' &&
			end=$(date +%s) &&
			echo " ◆ $APPNAME is updated, $((end - start)) seconds elapsed!" &
		fi
	else
		echo " ✖ $APPNAME is read-only, cannot update it!"
	fi
}

[ivan-hc]

maybe the only line you must change is

sh -x "$APPSPATH"/"$arg"/AM-updater >/dev/null 2>&1 | echo -ne ' Updating "'"$APPNAME"'"...\r' &&

and you need to add an if/fi condition to that

[ivan-hc]

@Samueru-sama I'm not sure on how the syntax would be, but this is another proof of concept/draft

function _update_app() {
	if [ -w "$APPSPATH"/"$arg"/AM-updater ]; then
		start=$(date +%s) &&
		if command -v appimageupdatetool >/dev/null 2>&1; then
			appimageupdatetool -Or "$APPSPATH"/"$arg"/AM-updater && chmod a+x "$APPSPATH"/"$arg"/AM-updater && echo "$version" > ./version && exit 0
		else
			sh -x "$APPSPATH"/"$arg"/AM-updater >/dev/null 2>&1
		fi \
		| echo -ne ' Updating "'"$APPNAME"'"...\r' &&
		end=$(date +%s) &&
		echo " ◆ $APPNAME is updated, $((end - start)) seconds elapsed!" &
	else
		echo " ✖ $APPNAME is read-only, cannot update it!"
	fi
}

[ivan-hc]

since I have less apps installed than you, its better I perform the test instead of you, you may reach the GHAPI limit too soon