Import RCTImageLoaderProtocol instead of RCTImageLoader to fix iOS build on RN>0.60 #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix looks good. Hope it will be merged and released soon. |
|
@fenderface66 Thanks for this! |
|
are you sure that it's for RN >= 60.0? or did you mean >= 61.0 In 60.6, RCTImageLoader is still being used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS is unable to build with RN>0.60 as RNFS is unable to import RCTImageLoader:
This PR implements the fix suggested on this open issue:
#768