Fix for issue #749: RNFS.uploadFiles upload raw not multipart #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RCT_EXPORT_METHOD for uploadFiles was casting the config option of binaryStreamOnly to it's internal params. The option comes through as an NSNumber as with all boolean primitives via the RCT methods. In objective-c comparing a NSNumber to a BOOL directly will do a pointer comparison, meaning that it will always be true if anything is set (eg: 0, 1, 999, fizzbuzz, as long as it's an object, the pointer will be true). To fix this you need to use the boolValue method on NSNumber to return a BOOL that matches the original intent.
|
Hi @itinance, please take a look at my PR, it fixes a bug that only affects iOS multipart fileUploads. |
|
👍 bless you, uploading files on ios was truly broken for me, the file upload request was indeed malformed due to this bug This PR fixed the issue and my server is now able to detect the files as part of the request. |
|
Thanks for this! |
|
No problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RCT_EXPORT_METHOD for uploadFiles was casting the config option of binaryStreamOnly to it's internal params. The option comes through as an NSNumber as with all boolean primitives via the RCT methods. In objective-c comparing a NSNumber to a BOOL directly will do a pointer comparison, meaning that it will always be true if anything is set (eg: 0, 1, 999, fizzbuzz, as long as it's an object, the pointer will be true). To fix this you need to use the boolValue method on NSNumber to return a BOOL that matches the original intent.
See: #749