Add pathForGroup method #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itinance
reviewed
Apr 26, 2017
|
|
||
| @ReactMethod | ||
| public void pathForGroup(String bundleNamed, Promise promise) { | ||
| // TODO: Not sure what equivalent would be? |
There was a problem hiding this comment.
I would suggest to reject this promise with a meaningful error message
|
Nice catch! Thanks for contributing. Do you might adding a section to the Readme describing the purpose of this method (with special warning that this is iOS only)? |
|
@itinance Yes of course. I will look into it next week. |
|
Done, please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two applications share the same group, a common folder can be accessed to share data between this two applications. This method will return the path to a shared group folder by the group's name. See containerURLForSecurityApplicationGroupIdentifier and [About App Sandbox](https://developer.apple.com/library/content/documentation/Security/Conceptual/AppSandboxDesignGuide/AboutAppSandbox/AboutAppSandbox.html#//apple_ref/doc/uid/TP40
011183) for reference.