Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UWP] downloadFile Promise should reject with a proper error if cancelled. #660

Closed
leoek opened this issue Apr 23, 2019 · 0 comments · Fixed by #661
Closed

[UWP] downloadFile Promise should reject with a proper error if cancelled. #660

leoek opened this issue Apr 23, 2019 · 0 comments · Fixed by #661

Comments

@leoek
Copy link
Contributor

leoek commented Apr 23, 2019 •
edited
Loading

Currently there is just a default Exception Handler which handles all exceptions which can occur. However cancellation is an expected error and should therefore have its own customized error.
leoek added a commit to leoek/react-native-fs that referenced this issue Apr 23, 2019
@leoek
itinance#660 add a custom error for cancelled downloadFile Requests
52623ae
@leoek leoek mentioned this issue Apr 23, 2019
Merged
itinance added a commit that referenced this issue Jul 16, 2019
@itinance
Merge pull request #661 from leoek/add-uwp-cancellation-exception
c1fe317 
#660 add a custom error for cancelled downloadFile Requests
@snyk-bot snyk-bot mentioned this issue Feb 29, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#660 add a custom error for cancelled downloadFile Requests leoek/react-native-fs
1 participant
@leoek