Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: fix misaligned memory access in setsockopt(). #91

Merged
merged 1 commit into from
Aug 20, 2019
Merged

network: fix misaligned memory access in setsockopt(). #91

merged 1 commit into from
Aug 20, 2019

Conversation

PiotrSikora
Copy link

Fixes envoyproxy#7968.

Signed-off-by: Piotr Sikora piotrsikora@google.com

@PiotrSikora
Copy link
Author

cc @lizan `

@PiotrSikora PiotrSikora changed the title network: fix misaligned access in setsockopt(). network: fix misaligned memory access in setsockopt(). Aug 20, 2019
@PiotrSikora
Copy link
Author

We don't have CI in istio/envoy, but I verified locally that this PR fixes misaligned memory access issue, and the PR upstream passed all the tests: envoyproxy#7969.

cc @istio/release-managers-1-1 @duderino @jplevyak

@lizan @PiotrSikora
Fix the alignement in optval of setsockopt when compiled with libc++. (…
d1188b6 
…envoyproxy#7958)

Description:
libc++ std::string may inline the data which results the memory is not
aligned to `void*`. Use vector instead to store the optval.

Detected by UBSAN with libc++ config. Preparation for envoyproxy#4251

Risk Level: Low
Testing: unittest locally
Docs Changes: N/A
Release Notes: N/A
Fixes envoyproxy#7968

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@lizan
Copy link

lizan commented Aug 20, 2019

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@PiotrSikora
Copy link
Author

Cherry-picked from envoyproxy#7958.

@duderino duderino merged commit 2a03059 into istio:release-1.1 Aug 20, 2019
jplevyak added a commit to jplevyak/envoy that referenced this pull request Sep 5, 2019
@jplevyak
Differentiate VM configuration and filter configuration. (istio#91)
3504b4e 
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplevyak jplevyak jplevyak approved these changes

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PiotrSikora @googlebot @lizan @jplevyak @duderino @istio-testing