Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM Null sandbox. #63

Merged
merged 31 commits into from
May 18, 2019
Merged

WASM Null sandbox. #63

merged 31 commits into from
May 18, 2019

Conversation

jplevyak
Copy link

@jplevyak jplevyak commented May 7, 2019

WASM Null sandbox.

@jplevyak
Copy link
Author

jplevyak commented May 8, 2019

Updated so this PR now contains only the Null Sandbox changes.

@jplevyak jplevyak mentioned this pull request May 9, 2019
Open
bianpengyuan
bianpengyuan reviewed May 12, 2019
View reviewed changes
Copy link

@bianpengyuan bianpengyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Reviews are from first pass code read. I will try to build stackdriver module with envoy and see if everything works well. Thanks!

source/extensions/common/wasm/null/null.cc Outdated Show resolved Hide resolved
api/wasm/cpp/BUILD Show resolved Hide resolved
include/envoy/grpc/async_client.h Outdated Show resolved Hide resolved
source/extensions/common/wasm/null/null.cc Show resolved Hide resolved
source/extensions/common/wasm/null/null_plugin_wrapper.cc Show resolved Hide resolved
source/extensions/common/wasm/null/null.cc Show resolved Hide resolved
@mandarjog mandarjog requested a review from lambdai May 12, 2019 14:45
bianpengyuan
bianpengyuan reviewed May 15, 2019
View reviewed changes
source/extensions/common/wasm/null/null.cc Outdated Show resolved Hide resolved
source/extensions/common/wasm/wasm.cc Show resolved Hide resolved
source/extensions/common/wasm/null/null.cc Outdated Show resolved Hide resolved
PiotrSikora
PiotrSikora reviewed May 16, 2019
View reviewed changes
source/extensions/common/wasm/null/null.cc Outdated Show resolved Hide resolved
source/extensions/common/wasm/null/null.cc Show resolved Hide resolved
source/extensions/common/wasm/null/null.cc Outdated Show resolved Hide resolved
source/extensions/common/wasm/null/null.cc Outdated Show resolved Hide resolved
source/extensions/common/wasm/null/null.cc Outdated Show resolved Hide resolved
source/extensions/common/wasm/wasm.cc Show resolved Hide resolved
source/extensions/common/wasm/wasm.cc Outdated Show resolved Hide resolved
source/extensions/common/wasm/wasm.cc Outdated Show resolved Hide resolved
source/extensions/common/wasm/wasm.h Show resolved Hide resolved
source/extensions/common/wasm/wasm.cc Outdated Show resolved Hide resolved
bianpengyuan
bianpengyuan reviewed May 17, 2019
View reviewed changes
api/wasm/cpp/proxy_wasm_enums.h Outdated Show resolved Hide resolved
source/extensions/common/wasm/wasm.cc Outdated Show resolved Hide resolved
api/wasm/cpp/proxy_wasm_impl.h Outdated Show resolved Hide resolved
source/extensions/common/wasm/null/proxy_wasm_externs.h Outdated Show resolved Hide resolved
@jplevyak jplevyak requested a review from PiotrSikora May 17, 2019 22:42
PiotrSikora
PiotrSikora reviewed May 17, 2019
View reviewed changes
api/wasm/cpp/BUILD Outdated Show resolved Hide resolved
source/extensions/common/wasm/null/proxy_wasm_externs.h Outdated Show resolved Hide resolved
source/extensions/common/wasm/wasm.h Show resolved Hide resolved
source/extensions/common/wasm/v8/v8.cc Outdated Show resolved Hide resolved
source/extensions/common/wasm/v8/v8.cc Outdated Show resolved Hide resolved
@jplevyak jplevyak requested a review from PiotrSikora May 18, 2019 00:41
PiotrSikora
PiotrSikora reviewed May 18, 2019
View reviewed changes
source/extensions/common/wasm/v8/v8.cc Outdated Show resolved Hide resolved
source/extensions/common/wasm/v8/v8.cc Outdated Show resolved Hide resolved
@jplevyak jplevyak requested a review from PiotrSikora May 18, 2019 01:32
PiotrSikora
PiotrSikora approved these changes May 18, 2019
View reviewed changes
Copy link

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@jplevyak jplevyak merged commit 1919461 into istio:wasm May 18, 2019
rlenglet pushed a commit that referenced this pull request Aug 13, 2019
@PiotrSikora
Revert "add time highlevel api (#59)" (#63)
bbbe056 
This reverts commit 9512348.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
myidpt pushed a commit that referenced this pull request May 11, 2021
@howardjohn
Implement handling of escaped slash characters in URL path (#63)
4cf81d2
istio-testing pushed a commit that referenced this pull request May 11, 2021
@myidpt @howardjohn
Implement handling of escaped slash characters in URL path (#63) (#322)
5a5f131 
Co-authored-by: John Howard <howardjohn@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bianpengyuan bianpengyuan bianpengyuan left review comments

@PiotrSikora PiotrSikora PiotrSikora approved these changes

@mandarjog mandarjog Awaiting requested review from mandarjog

@lambdai lambdai Awaiting requested review from lambdai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jplevyak @PiotrSikora @mandarjog @bianpengyuan