Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add received log line for HandleEventForDeployment #290

Merged
merged 1 commit into from
May 8, 2023

Conversation

kpharasi
Copy link
Collaborator

@kpharasi kpharasi commented May 8, 2023

Add a log line similar to the one in HandleEventForRollout

@vinay-g vinay-g merged commit 0d622ac into istio-ecosystem:master May 8, 2023
@adilfulara
Copy link
Collaborator

@vinay-g @kpharasi wont this be very chatty? Would it help if we had this at debug and incremented a metric counter instead ?

@vinay-g
Copy link
Collaborator

vinay-g commented May 9, 2023

@adilfulara Yup you are right. its intended at the moment to pinpoint few performance issues we are seeing. We will have a followup PR to clean log events like this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants