[MESH-3036] - Set consecutive5xxErrors to 0 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vgonuguntla <vinay_gonuguntla@intuit.com>
vinay-g
force-pushed
the
oss-MESH-3036
branch
3 times, most recently
from
035f55b
to
0fcb247
Compare
Signed-off-by: vgonuguntla <vinay_gonuguntla@intuit.com>
|
LGTM. @vinay-g WDYT about reducing the base_ejection_time and setting max_ejection_time to 300s. So that outlier doesn't become a bottleneck! As of now, we are not setting max_ejection_time. (We can take this up separately) |
|
@itsLucario Yup will put that in a separate PR, have to discuss with Anil on that also need to discuss setting the maxEjectionPercent. Since the 100% will cause blackout in multi region scenarios' |
itsLucario
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsecutiveGatewayErrors in DestinationRule do not take affect the value is higher that consecutive5xxErrors.
In envoy consecutive5xxErrors value is set to 5 by default.
consecutive5xxErrors needs to be set to 0, to explicitly disable the 5XX error outlier detection to kick in.