Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Deleting a GTP would result in deleting the only endpoint of a service #234

Closed
shriramsharma opened this issue Jun 24, 2022 · 0 comments · Fixed by #235
Closed

[BUG]: Deleting a GTP would result in deleting the only endpoint of a service #234

shriramsharma opened this issue Jun 24, 2022 · 0 comments · Fixed by #235
Labels
bug Something isn't working

Comments

@shriramsharma
Copy link
Collaborator

Describe the bug
With this PR #223 we have an issue where a delete GTP event could cause the only service entry endpoint to be deleted since we're passing down the same admiral event down to the modifyServiceEntryForNewServiceOrPod func.
@shriramsharma shriramsharma added the bug Something isn't working label Jun 24, 2022
shriramsharma added a commit to shriramsharma/admiral that referenced this issue Jun 24, 2022
@shriramsharma
Fixes: istio-ecosystem#234
a53bebf 
force GTPs to update only

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
@shriramsharma shriramsharma mentioned this issue Jun 24, 2022
Merged
aattuluri pushed a commit that referenced this issue Jun 24, 2022
@shriramsharma
Force all GTP events to update only (#235)
3cd7ac8 
* Fixes: #234

force GTPs to update only

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>

* fixed linting errors

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
asushanthk pushed a commit that referenced this issue Jul 21, 2022
@shriramsharma
Force all GTP events to update only (#235)
5fb9655 
* Fixes: #234

force GTPs to update only

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>

* fixed linting errors

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: sa <sushanth_a@intuit.com>
asushanthk pushed a commit that referenced this issue Jul 21, 2022
@shriramsharma
Force all GTP events to update only (#235)
f627d99 
* Fixes: #234

force GTPs to update only

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>

* fixed linting errors

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: sa <sushanth_a@intuit.com>
itsLucario pushed a commit to itsLucario/admiral that referenced this issue Aug 9, 2022
@shriramsharma
Force all GTP events to update only (istio-ecosystem#235) (istio-ecos…
f1a43a4 
…ystem#132)

* Fixes: istio-ecosystem#234

force GTPs to update only

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>

* fixed linting errors

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>

Co-authored-by: aattuluri <AnilKumar_Attuluri@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

force GTPs to update only shriramsharma/admiral
1 participant
@shriramsharma