Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] 회원가입, 로그인 페이지 UI & mock API 구성 #35

Merged
merged 3 commits into from
Jul 28, 2023
Merged

[FE] 회원가입, 로그인 페이지 UI & mock API 구성 #35

merged 3 commits into from
Jul 28, 2023

Conversation

youzysu
Copy link
Member

@youzysu youzysu commented Jul 28, 2023

Issues

What is this PR? 👓

  • AuthPage(Login/Signup) UI 구현
  • /login, /signup mock API 구성 & 요청

Key changes 🔑

  • Auth index Page를 Login으로 설정
  • useInput Hooks 생성: 이후 확장성을 고려하여 useInput hook으로 validate 로직 분리
  • Login & Signup page 분리

To reviewers 👋

  • Login & Signup AuthForm 로직이 거의 중복이라 요청하는 API만 달라서 합치는게 나을지 고민중이에요.
  • 아직 Response accessToken, api 함수 구현은 진행중입니다!

@youzysu
issue-tracker-08#30 feat: Login & Signup page Layout
4d0b46c 
- auth index Login으로 설정
- 이후 확장성을 고려하여 useInput hook으로 validate 로직 분리
- 가독성을 고려하여 Login & Signup page 분리 (중복 고민)
@youzysu
issue-tracker-08#30 feat: 회원가입 & 로그인 mock API 구성 & 요청
80d3392 
- 회원가입: 아이디 중복 검증
- 로그인: 회원 유무, 비밀번호 일치 검증
@youzysu youzysu added this to the [FE] Sprint #01 milestone Jul 28, 2023
@youzysu youzysu requested a review from Kakamotobi July 28, 2023 02:15
@youzysu youzysu self-assigned this Jul 28, 2023
@Kakamotobi Kakamotobi merged commit f9bb4ff into issue-tracker-08:fe-w1 Jul 28, 2023
@youzysu youzysu mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kakamotobi Kakamotobi Kakamotobi approved these changes

Assignees

@youzysu youzysu

Labels
front-end
Projects
None yet
Milestone
[FE] Sprint #01
Development

Successfully merging this pull request may close these issues.
2 participants
@youzysu @Kakamotobi