Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] TextInput placeholder state & style 수정 #27

Merged

Conversation

youzysu
Copy link
Member

@youzysu youzysu commented Jul 27, 2023

Issues

What is this PR? 👓

  • TextInput placeholder 스타일 관련 state & style 수정

Key changes 🔑

  • 다크모드를 확인하다가 placeholder에 스타일이 적용이 안되는걸 발견했어요.
  • placeholder는 typingState로 관리할 필요가 없어서 제외했어요.

To reviewers 👋

  • merge 요청드리기 전에 더 꼼꼼하게 확인할게요 🥲
  • 요거 이전 스쿼시 커밋이랑 합쳐도 좋을 것 같네요. 이따가!

@youzysu youzysu added this to the [FE] Sprint #01 milestone Jul 27, 2023
@youzysu youzysu requested a review from Kakamotobi July 27, 2023 03:26
@youzysu youzysu self-assigned this Jul 27, 2023
@youzysu youzysu changed the title #20 design: TextInput placeholder state & style 수정 [FE] TextInput placeholder state & style 수정 Jul 27, 2023
@Kakamotobi Kakamotobi merged commit 7c279e4 into issue-tracker-08:fe-w1 Jul 27, 2023
youzysu added a commit to youzysu/issue-tracker-max that referenced this pull request Jul 27, 2023
* issue-tracker-08#20 design: Text Input Component UI

* issue-tracker-08#20 design: input style reset 추가

* issue-tracker-08#20 refactor: TextInput Component 리뷰 반영

- height 대신 variant props로 수정
issue-tracker-08#20 design: TextInput placeholder state & style 수정 (issue-tracker-08#27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants