-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --version flag for CLI #308
Conversation
Hi @isaacs - I had a couple of questions as this repo doesn't have a contributing guide.
|
Hi, @ajitzero thanks! Yes, please add a test for the new cli flag. Should be added to I think it's best to squash commits prior to landing, at least to a "one commit per thing" kind of format, where tests pass on all commits, etc. But of course, sometimes it's easier to review in a more granular state. If you wanna squash it, great, if not, I can easily do it on my end when landing. |
If you rebase on main and re-run |
Hi @isaacs - sorry, I just got time again to look at this.
I see the above results for the Let's cover this with a different PR first and hold off on merging this one (even though it's unlikely to make a difference). |
Just added a test for I've also added |
I created a separate issue (#310) to track this. We can merge this PR as it isn't relevant to the problem. |
05d8ef1
to
3ab6f36
Compare
3ab6f36
to
6de86bf
Compare
Fixes #302