Adds lidar pattern for raycaster sensor #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Mayankm96
reviewed
Jul 2, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/patterns/patterns_cfg.py
Show resolved
Hide resolved
Dhoeller19
approved these changes
Jul 4, 2024
Mayankm96
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Looks good. Needs update in the docs here: https://github.com/isaac-sim/IsaacLab/edit/main/docs/source/api/lab/omni.isaac.lab.sensors.patterns.rst
Mayankm96
reviewed
Jul 5, 2024
source/extensions/omni.isaac.lab_assets/omni/isaac/lab_assets/velodyne.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Jul 5, 2024
source/extensions/omni.isaac.lab_assets/omni/isaac/lab_assets/anymal.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
|
Thanks a lot for the contribution! |
mohanksriram
pushed a commit
to mohanksriram/IsaacLab
that referenced
this pull request
Jul 12, 2024
# Description Add a lidar pattern for the `RayCaster` sensor. The pattern is determined by number of channels, horizontal and vertical field of view and corresponding horizontal resolution. An example config for a Velodyne VLP 16 is provided. ## Type of change - New feature (non-breaking change which adds functionality) ## Screenshots  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description Add a lidar pattern for the `RayCaster` sensor. The pattern is determined by number of channels, horizontal and vertical field of view and corresponding horizontal resolution. An example config for a Velodyne VLP 16 is provided. ## Type of change - New feature (non-breaking change which adds functionality) ## Screenshots  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a lidar pattern for the
RayCastersensor. The pattern is determined by number of channels, horizontal and vertical field of view and corresponding horizontal resolution. An example config for a Velodyne VLP 16 is provided.Type of change
Screenshots
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there