Correct the Guid used when writing the user defined properties sectio… #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n, and use WellKnownFMTID instead of duplicating the guids in several places
Numpsy
commented
Feb 13, 2024
| @@ -248,7 +248,7 @@ public void Save(CFStream cfStream) | |||
| PropertyContext = UserDefinedProperties.Context | |||
| }; | |||
|
|
|||
| ps.FMTID1 = new Guid("{D5CDD502-2E9C-101B-9397-08002B2CF9AE}"); | |||
| ps.FMTID1 = new Guid(WellKnownFMTID.FMTID_UserDefinedProperties); | |||
There was a problem hiding this comment.
Noticed whilst testing that this was writing the DocSummaryInformation guid into the user defined properties section, when it should be the UserDefinedProperties guid.
I also changed it to use the 'WellKnownFMTID' values instead of duplicating the strings, though that's not required for the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n, and use WellKnownFMTID instead of duplicating the guids in several places