[LLVMGPU] Switch to new pass generation tablegen definitions. #18213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hanhanW <hanhan0912@gmail.com>
This is mostly an NFC change. The revision applies a little cleanups: - Switch a couple of passes to follow `create.*Pass` naming convention. Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
requested review from
MaheshRavishankar,
qedawkins,
kuhar and
Groverkss
as code owners
MaheshRavishankar
approved these changes
Aug 14, 2024
|
It looks like there are regressions in sdxl, I'll take a look |
|
The regression is gone after I rebased it to main branch. It looks like a noise: https://github.com/iree-org/iree/actions/runs/10379225104/job/28737595634?pr=18213 I'll land the PR once the CI is green, just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly an NFC change. The revision applies a little cleanups:
create.*Passnaming convention.Passes.htoPasses.td.