Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix importing softsign secp256k1 key type #790

Merged
merged 3 commits into from
Oct 16, 2023
Merged

fix importing softsign secp256k1 key type #790

merged 3 commits into from
Oct 16, 2023

Conversation

mkaczanowski
Copy link
Contributor

Description

This change along with updated (prior this PR) version of tendermint-rs adds support for softsign import of secp256k1 key type. Tested via:

$ cat test_priv_validator_key.json
{
  "address": "0799B6E1F13F1ECC7E891765F499A73665F42866",
  "pub_key": {
    "type": "tendermint/PubKeySecp256k1",
    "value": "A2hdb2LlTQ+sxqpknkA2v0RgQ6a6Q4t5OwhebIqSr8qu"
  },
  "priv_key": {
    "type": "tendermint/PrivKeySecp256k1",
    "value": "aVmw0npSBEqPU4v6qEZ9o3z5nCpHjicwFDdIBRUbSrM="
  }
}

$ ./target/debug/tmkms softsign import test_priv_validator_key.json out.key
2023-10-16T21:25:06.303245Z  INFO tmkms::commands::softsign::import: Imported Secp256k1 private key to out.key

$ cat out.key 
aVmw0npSBEqPU4v6qEZ9o3z5nCpHjicwFDdIBRUbSrM=

Fixes

#761

Copy link
Member

@tony-iqlusion tony-iqlusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tony-iqlusion tony-iqlusion merged commit 791e0b9 into iqlusioninc:main Oct 16, 2023
8 checks passed
@tony-iqlusion tony-iqlusion mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants