This repository has been archived by the owner on Dec 6, 2022. It is now read-only.
fix: replace node buffers with uint8array #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accepts and emits `Uint8Array`s instead of node `Buffer`s but converts them internally because `bitcoinjs-lib` only understands `Buffer`s. BREAKING CHANGE: - `util.serialize` returns `Uint8Array`s
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 67 69 +2
=========================================
+ Hits 67 69 +2
Continue to review full report at Codecov.
|
7 tasks
vmx
approved these changes
Aug 4, 2020
64 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepts and emits
Uint8Arrays instead of nodeBuffers but convertsthem internally because
bitcoinjs-libonly understandsBuffers.BREAKING CHANGE:
util.cidreturns v1CIDs