feat: introduce car explorer (CAR import) #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
previously requested changes
Apr 13, 2022
There was a problem hiding this comment.
LGTM, switched to ipld-explorer-components@2.1.0 and cleaned up some locale deps.
Things to fix before we merge:
- CAR import does not work when in-memory js-ipfs (
ipfs-coreNPM dependency) is used- see preview at https://bafybeigdetevwemjzlmd3fhmf652fvgfkcek4r3dbs5skhw4eajfc5appa.on.fleek.co/ – console shows
TypeError: iterable[Symbol.iterator] is not a functionerror
- see preview at https://bafybeigdetevwemjzlmd3fhmf652fvgfkcek4r3dbs5skhw4eajfc5appa.on.fleek.co/ – console shows
- UX of selecting a CAR:
- when CAR file is selected, nothing happens. Took me a moment to realize I need to click "Explore"
- this is confusing, no need for this additional click – we should open the root CID as soon
dag.importis finished.
|
The issue here will be resolved by PR ipfs/ipld-explorer-components#317 |
alvin-reyes
dismissed
lidel’s stale review
Changes are now applied based on the review points and feedbacks.
lidel
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change introduce the
<IpldCarExplorerForm />on the explorer.ipld.io.Related PR
ipfs/ipld-explorer-components#313
Verification