Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade OpenTelemetry dependencies #9736

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Conversation

guseggert
Copy link
Contributor

This also moves the test to Go and changes all the "special feature" env vars that have special dependency/build requirements (Docker, Fuse, plugins) to be opt-in, so that tests work by default when you run "go test".

Resolves #9677, #9676, #9675

@guseggert guseggert self-assigned this Mar 18, 2023
@guseggert guseggert force-pushed the test/otel-upgrade branch 5 times, most recently from 4483b00 to 0bb6038 Compare March 18, 2023 13:35
@guseggert guseggert marked this pull request as ready for review March 18, 2023 13:47
@guseggert guseggert requested a review from Jorropo March 18, 2023 13:48
Jorropo added a commit that referenced this pull request Mar 23, 2023
Jorropo added a commit that referenced this pull request Mar 25, 2023
Jorropo added a commit that referenced this pull request Mar 27, 2023
Jorropo added a commit that referenced this pull request Mar 27, 2023
Jorropo added a commit that referenced this pull request Mar 27, 2023
Jorropo added a commit that referenced this pull request Mar 27, 2023
Jorropo added a commit that referenced this pull request Mar 27, 2023
Jorropo added a commit that referenced this pull request Mar 27, 2023
Jorropo added a commit that referenced this pull request Mar 27, 2023
Jorropo added a commit that referenced this pull request Mar 28, 2023
Jorropo added a commit that referenced this pull request Mar 28, 2023
Jorropo added a commit that referenced this pull request Mar 28, 2023
Jorropo added a commit that referenced this pull request Mar 28, 2023
Jorropo added a commit that referenced this pull request Mar 28, 2023
Jorropo added a commit that referenced this pull request Mar 28, 2023
Jorropo added a commit that referenced this pull request Mar 28, 2023
Jorropo added a commit that referenced this pull request Mar 29, 2023
guseggert pushed a commit that referenced this pull request Mar 29, 2023
@Jorropo
Copy link
Contributor

Jorropo commented Mar 29, 2023

Included in f592db7

@Jorropo Jorropo closed this Mar 29, 2023
@Jorropo
Copy link
Contributor

Jorropo commented Mar 29, 2023

Actually this have other than go.mod changes.

This is so that by default, you can run tests without having to set up
any of these things and without having to set env vars on the test
runner. This makes it easier to run the CLI tests in your IDE without
having to setup special env vars to skip the Docker, plugin, and fuse tests.
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Rebased and waiting for ✅

@hacdias hacdias enabled auto-merge (squash) April 5, 2023 11:12
@hacdias hacdias merged commit 1b3e443 into master Apr 5, 2023
@hacdias hacdias deleted the test/otel-upgrade branch April 5, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants