Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 0.19 changelog #9707

Merged
merged 3 commits into from
Mar 20, 2023
Merged

docs: 0.19 changelog #9707

merged 3 commits into from
Mar 20, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Mar 8, 2023

This is mostly the only "big" user facing changes except resource manager, the rest is background work.

@Jorropo Jorropo requested a review from BigLep March 8, 2023 17:00
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jorropo : isn't this already covered in https://github.com/ipfs/kubo/blob/master/docs/changelogs/v0.18.md#new-default-pubsubseenmessagesstrategy ?

If so, then that means our only thing specific in Kubo was resource manager and everything else was in the go-libipfs layer? A couple of things about this:

  1. Are we sure? There's nothing that percolated to the HTTP Gateway that Kubo exposes? (@hacdias or @lidel to confirm)
  2. This is upping the importance of making sure our changelogs in go-libipfs are better so someone can go and learn about the improvements there.

@BigLep BigLep mentioned this pull request Mar 8, 2023
@lidel lidel changed the title docs: add PubSub to changelog docs: 0.19 changelog Mar 8, 2023
@lidel
Copy link
Member

lidel commented Mar 8, 2023

Added Gateway section with IPIP-351 changes – fb663c6.

We also did ipfs/boxo#155, ipfs/boxo#150 and ipfs/boxo#187 but I feel these are low-level changes that end user is not interested about. Lmk if we should add a sentence about these.

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additions @lidel . They look good to me.

@Jorropo : I think you an merge once you've confirmed whether we aren't being redundant on "PubSub message caching improvements".

Updates also slipped in for #9708

@BigLep
Copy link
Contributor

BigLep commented Mar 19, 2023

@Jorropo: can you please get this resolved and merged? Please confirm whether the pubsub comments are needed per #9707 (review)

@galargh
Copy link
Contributor

galargh commented Mar 20, 2023

I'm merging this as-is. Please feel free to update the changelog later.

@galargh galargh merged commit 75998d3 into master Mar 20, 2023
galargh added a commit that referenced this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants