Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove circleci config #9687

Merged
merged 9 commits into from
Mar 21, 2023
Merged

ci: remove circleci config #9687

merged 9 commits into from
Mar 21, 2023

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Mar 2, 2023

Here's the comparison between CircleCI vs GitHub Actions. It gives me confidence we can retire CircleCI and embrace GitHub Actions as the main CI provider.

I'm going to resolve conflicts once we're ready to merge because the workflows name changes from this PR affect how workflows show up in GitHub UI/are described by GitHub API so I want to minimise the number of times we're going back and forth on old-new names.

I'll also merge this - ipfs/github-mgmt#126 - just before merging this.

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks @galargh . Looks good to me but I'm not close to the specifics. Will let someone else approve.

@guseggert
Copy link
Contributor

Would be nice to have an easy way to find test failures for unit tests, CircleCI has a nice UI for that but I can't find one in GH Actions.

Also is there some similar functionality for finding flaky tests like CircleCI has?

@guseggert
Copy link
Contributor

Also can we not merge this until after 0.19 is released? Just so we test another release w/ GH Actions before pulling the trigger.

@galargh
Copy link
Contributor Author

galargh commented Mar 13, 2023

Would be nice to have an easy way to find test failures for unit tests, CircleCI has a nice UI for that but I can't find one in GH Actions.

#9719 introduces nice markdown summaries for failed tests. We can even consider posting them directly to PRs.

Also is there some similar functionality for finding flaky tests like CircleCI has?

Not built-in but there is prior-art in this area. go-libp2p has tooling for this. We could generalise it and set up for Kubo too. Would you need it straight away or could it wait for a little while?

Also can we not merge this until after 0.19 is released? Just so we test another release w/ GH Actions before pulling the trigger.

No problem, I'll merge after 0.19 👍

@guseggert
Copy link
Contributor

Would you need it straight away or could it wait for a little while?

I don't think we "need" it, it'd be nice if we had something similar in GH, as it makes understanding failed tests and managing flakes easier, but we can live without it.

@galargh
Copy link
Contributor Author

galargh commented Mar 14, 2023

Would you need it straight away or could it wait for a little while?

I don't think we "need" it, it'd be nice if we had something similar in GH, as it makes understanding failed tests and managing flakes easier, but we can live without it.

Got it! We will definitely have flaky test reporting - that's on our agenda for this year - and Kubo will surely be one of the first projects where we set it up. I'll keep you posted on this.

Also, if you have any other ideas for what you'd want to see in our CI, don't hesitate to reach out on #ipdx 😸

@guseggert
Copy link
Contributor

I'm ready to approve but I'm just holding off until 0.19 is released to avoid any mishaps.

@galargh galargh requested a review from guseggert March 21, 2023 10:32
@galargh galargh force-pushed the no-circleci branch 2 times, most recently from e59fa19 to f8a76d3 Compare March 21, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants