fix: restore wire format for /api/v0/routing/get #9639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
requested changes
Feb 9, 2023
There was a problem hiding this comment.
@hacdias mind adding test/cli that executes ipfs routing get --enc=json and confirm expected JSON fields are present in the wire format?
As for Put, maybe we can return empty array for peers (or only return self, if at least one is needed) for now?
This way we don't need to change the interface, but still have old JSON response.
I don't think people care about these addrs, majority cares about Put doing the Put, and ignores the adds.
|
@lidel done and put too (with ID only). |
lidel
changed the title
lidel
changed the title
lidel
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #9638. I can only revert the wire format for
routing/get. Forput, we would need more information from the.Routing.Putto tell us in which peers the record was stored. However, that implies we would need to change the interface yet again. I would rather not do it, or do it in a different PR.Closes #9638