Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub multibase encoding #8933

Merged
merged 3 commits into from
May 6, 2022
Merged

pubsub multibase encoding #8933

merged 3 commits into from
May 6, 2022

Conversation

TMoMoreau
Copy link
Contributor

Adds clarification for pubsub multibase encoding over HTTP RPC for issue ipfs/ipfs-docs#1007

Adds clarification for pubsub multibase encoding over HTTP RPC for issue ipfs/ipfs-docs#1007
@welcome
Copy link

welcome bot commented May 3, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@TheDiscordian
Copy link
Member

CC @johnnymatthews (you asked to be pinged about this once the PR is up once upon a time)

@johnnymatthews
Copy link
Contributor

Lovely stuff. Just need a maintainer of this repo to merge and we're good to go!

@BigLep BigLep merged commit 9a84a4f into ipfs:master May 6, 2022
guseggert pushed a commit that referenced this pull request Jun 8, 2022
* pubsub multibase encoding

Adds clarification for pubsub multibase encoding over HTTP RPC for issue ipfs/ipfs-docs#1007

* Grammatical change

* Moved period
guseggert pushed a commit that referenced this pull request Jun 8, 2022
* pubsub multibase encoding

Adds clarification for pubsub multibase encoding over HTTP RPC for issue ipfs/ipfs-docs#1007

* Grammatical change

* Moved period

(cherry picked from commit 9a84a4f)
guseggert pushed a commit that referenced this pull request Jun 8, 2022
* pubsub multibase encoding

Adds clarification for pubsub multibase encoding over HTTP RPC for issue ipfs/ipfs-docs#1007

* Grammatical change

* Moved period

(cherry picked from commit 9a84a4f)
guseggert pushed a commit that referenced this pull request Jun 8, 2022
* pubsub multibase encoding

Adds clarification for pubsub multibase encoding over HTTP RPC for issue ipfs/ipfs-docs#1007

* Grammatical change

* Moved period

(cherry picked from commit 9a84a4f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants