Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gw): extract logical functions to improve readability #8885

Merged
merged 3 commits into from
Apr 15, 2022
Merged

chore(gw): extract logical functions to improve readability #8885

merged 3 commits into from
Apr 15, 2022

Conversation

justindotpub
Copy link
Contributor

Another take at #8883 from my personal account this time.

@justindotpub justindotpub mentioned this pull request Apr 14, 2022
Closed
3 tasks
Jorropo
Jorropo requested changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely clearer. thx 🙂

Just a few final things.

core/corehttp/gateway_handler.go Outdated Show resolved Hide resolved
core/corehttp/gateway_handler.go Outdated Show resolved Hide resolved
core/corehttp/gateway_handler.go Outdated Show resolved Hide resolved
core/corehttp/gateway_handler.go Outdated Show resolved Hide resolved
core/corehttp/gateway_handler.go Outdated Show resolved Hide resolved
@justindotpub
Copy link
Contributor Author

I believe I've addressed everything @Jorropo. Let me know if I missed anything, and thanks again for the feedback.

Jorropo
Jorropo approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@Jorropo Jorropo merged commit e07baf5 into ipfs:master Apr 15, 2022
@justindotpub justindotpub deleted the justincjohnson/refactor-gateway branch April 15, 2022 14:10
@justindotpub justindotpub mentioned this pull request Apr 15, 2022
Merged
@aschmahmann aschmahmann mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorropo Jorropo Jorropo approved these changes

@lidel lidel Awaiting requested review from lidel lidel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justindotpub @Jorropo