Update Go version to 1.17 #8815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
changed the title
aschmahmann
force-pushed
the
feat/update-go-version
branch
from
6e209e5
to
fc6e45f
Compare
aschmahmann
commented
Mar 22, 2022
| @@ -1,6 +1,6 @@ | |||
| include mk/header.mk | |||
|
|
|||
| $(d)_plugins:=$(d)/git $(d)/dagjose $(d)/badgerds $(d)/flatfs $(d)/levelds $(d)/peerlog | |||
| $(d)_plugins:= | |||
There was a problem hiding this comment.
All of the plugins have been removed here due to #8550 (i.e. old xxhash dependencies). Note: they're still part of the binary because we pre-bundle them in.
If we upgrade the version of go-libp2p-quic-transport and prometheus/client_golang we should be able to bring back some of the building here as a test mechanism to make sure they can build.
Note: Badger will not be able to be built as a plugin because it is using xxhash v1
aschmahmann
force-pushed
the
feat/update-go-version
branch
2 times, most recently
from
2ecb298
to
de918c7
Compare
3 tasks
Merged
3 tasks
aschmahmann
force-pushed
the
feat/update-go-version
branch
2 times, most recently
from
3562f45
to
e53de2d
Compare
|
2022-04-07 conversation:
|
rvagg
approved these changes
Apr 8, 2022
aschmahmann
force-pushed
the
feat/update-go-version
branch
from
78828e3
to
671a576
Compare
13 tasks
gmasgras
pushed a commit
that referenced
this pull request
May 3, 2022
* remove building the pre-bundled plugins as shared objects in makefile * chore: update go version to minimum of 1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this has been scoped to just support 1.17.