Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmds/files/ls): recursive listing #8668

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(cmds/files/ls): recursive listing #8668

wants to merge 2 commits into from

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented Jan 12, 2022 •
edited
Loading

Rough prototype for review. Sharness tests missing.

Follows unix ls -R behavior. Example:

$ ipfs init
$ ipfs files mkdir -p /1/2/3/4

$ ipfs files ls -R 
/:
1

/1:
2

/1/2:
3

/1/2/3:
4

/1/2/3/4:

Closes #8104.

@schomatis schomatis self-assigned this Jan 12, 2022
schomatis
schomatis commented Jan 12, 2022
View reviewed changes
core/commands/files.go
@@ -567,6 +632,9 @@ Examples:
fmt.Fprintf(w, "%s\n", o.Name)
}
}
if out.Path != "" {
fmt.Fprint(w, "\n")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should skip this for the last entry we list. What would be the cleanest way to signal that? Closing the response?

@schomatis schomatis mentioned this pull request Jan 13, 2022
Open
3 tasks
@BigLep BigLep added this to the Best Effort Track milestone Mar 10, 2022
@BigLep BigLep marked this pull request as ready for review March 10, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Awaiting requested review from Stebalien

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

At least 1 approving review is required to merge this pull request.

Assignees

@schomatis schomatis

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Status: 🔎 In Review
Milestone
Best Effort Track
Development

Successfully merging this pull request may close these issues.

MFS ls recursive
2 participants
@schomatis @BigLep