New net interface #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: not yet wired. |
Closed
| return false | ||
| } | ||
| return bool(r[0]&0x80 == 0x80) | ||
| } |
There was a problem hiding this comment.
@perfmode @whyrusleeping heads up -- Request uses the per-msg RequestID nonce to also identify whether it's a request or a response (based on the first bit). (lmk if you think this is too sketchy)
There was a problem hiding this comment.
When can r == nil?
My concern would be around future-proofing. Will this representation be resistant to errors introduced by updates and versioning incompatibilities?
There was a problem hiding this comment.
Ehhh... im going to lean towards 'sketchy'. Like, yeah it works, but it should be commented to hell and back if were going to keep it.
There was a problem hiding this comment.
@perfmode r == nil when messages do not want a RequestID associated -- i.e. they're not requests.
@whyrusleeping Yeah, it's sketchy. It feels so wrong to use a whole protobuf for a bit thought >.< -- i guess it is technically TRTTD.
| // speaking to (i.e. peer.ID). In terms of moving around simple addresses | ||
| // -- instead of an (ID, Addr) pair -- we can use: | ||
| // | ||
| // /ip4/10.20.30.40/tcp/1234/ipfs/Qxhxxchxzcncxnzcnxzcxzm |
There was a problem hiding this comment.
Should we have some sort of extra functionality added to multiaddr? Maybe add pluggable protocols so ipfs can specify the 'ipfs peer' protocol which denotes an id that is expeced from the connection?
There was a problem hiding this comment.
yeah, sounds good. we can allocate a multiaddr number and all.
think b58 is good enough to have multiaddr default to for protocols whose string representations it doesn't know? could do hex. Oh damnit b58 will run into trouble on case sensitive OSes....
whyrusleeping
force-pushed
the
master
branch
from
609a71b
to
5fafaa4
Compare
|
|
||
| // add all the peers we got first. | ||
| for _, p := range peers { | ||
| r.addPeerToQuery(p, nil) // don't have access to self here... |
There was a problem hiding this comment.
Hrm... having a reference to outself here might be useful. I had issues without it before.
|
@jbenet Recall services register handlers on the network. These handlers are called when inbound messages arrive. What does it mean for the handler to return an error to the network layer? |
|
@perfmode good point, that doesn't make much sense. See https://github.com/jbenet/go-ipfs/blob/net/net/service/service.go#L183-L188 Think it should just return a message, and handle/log/whatever its own error? |
|
@jbenet @whyrusleeping merged this into net already, but still want to make sure you're aware. |
added 14 commits
September 22, 2014 04:06
true -> always send to peer false -> use ledger-based strategy described in IPFS paper draft 3
failing due to nil pointer dereference
|
|
|
AHHHHHHHHHHHHHHH!!!! |
|
The smile on my face right now. |
|
|
@jbenet o.o that changelist.... |
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
update libp2p to 4.4.3
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.