http api: makes sure header is sent even when r is not ready yet. fixes #3304 #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jan Winkelmann <j-winkelmann@tuhh.de>
whyrusleeping
requested changes
Oct 15, 2016
| @@ -298,6 +298,9 @@ func flushCopy(w io.Writer, r io.Reader) error { | |||
| return err | |||
| } | |||
| for { | |||
| // flush to send header when r is not ready yet | |||
| f.Flush() | |||
There was a problem hiding this comment.
probably want to check and handle the error here, just in case
There was a problem hiding this comment.
Flush doens't return an error, that's why the tests failed :D
License: MIT Signed-off-by: Jan Winkelmann <j-winkelmann@tuhh.de>
|
I now check the error. Also I removed the flush at the bottom of the loop so it doesn't flush pointlessly. |
|
Tests are failing now... i'm guessing removing that final flush wasnt quite right |
License: MIT Signed-off-by: Jan Winkelmann <j-winkelmann@tuhh.de>
License: MIT Signed-off-by: Jan Winkelmann <j-winkelmann@tuhh.de>
|
Can you squash it, we don't want to have any commits with build/test failures as it makes git bisecting much harder. |
whyrusleeping
approved these changes
Oct 18, 2016
|
@Kubuxu uh, sorry. next time! |
liliuhai
added a commit
to peersafe/go-ipfs
that referenced
this pull request
Dec 26, 2016
* commit '6f3ae5da293f971c09e3e6fc0763aeca04ba98d3': rename DataSize to FileSize update HashOnRead validation to properly support cids http api: makes sure header is sent even when r is not ready yet. fixes ipfs#3304 (ipfs#3305) fix add/cat of small files raw dag: make raw nodes work in cat and get, add tests feat: make metrics injection log an error instead of warning test: check if metrics work in sharness Fix metrics being injected after node initalization unixfs: allow use of raw merkledag nodes for unixfs files ds-help: add helper func to convert from Cid to DsKey and the reverse cli: refactor to expose argument parsing functionality # Conflicts: # core/commands/add.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise API clients block on pubsub subscriptions until the first packet is sent (see, well, #3304).