ipfs command uses config RPC address when acting as a client #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor fix to dht debugging string
|
hmm... Im gonna wanna merge this with feat/snappy-cmd before master |
| err = daemon.SendCommand(com, dAddr) | ||
| if err != nil { | ||
| // Do locally | ||
| n, err := localNode(confDir, false) |
There was a problem hiding this comment.
worried about code dup everywhere. room for errors. can we abstract this out into a function?
|
LGTM, but yes, as @whyrusleeping mentioned, this should prob be rebased on top of |
|
I should have been working off of feat/snappy-cmd this whole time, these changes are moot. |
jbenet
referenced
this pull request
Sep 28, 2014
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
Disallow overwriting new records with older records on DHT PUT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than send commands to the hardcoded "localhost:12345", they should be sent to the RPCAddress that is set in the config. I changed the daemon client function ''SendCommand'' to take a multiaddr rather than a "host:port" string. This seemed like a reasonable thing to do since ''NewDaemonListener'' takes a multiaddr as its bind argument.
I also made a minor fix to a dht debugging printf.