Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Ping (minor) #104

Merged
merged 2 commits into from
Sep 23, 2014
Merged

Fixed Ping (minor) #104

merged 2 commits into from
Sep 23, 2014

Conversation

jbenet
Copy link
Member

@jbenet jbenet commented Sep 23, 2014

No description provided.

This fixes the broken pinging. (the issue was the cluster
level, it's bein set incorrectly (off by one))

Anyway, this works now:

    [peer: QmfQTbC3LxfpK5WoyHW2WgnAzo6d6GePuq2wHTsJNXM5PS] Sent message type: 'PING' [to = QmNXUeFrV9gxR4aqJddEsfhWZLSJrUsfpUSeRb3R7xvSp9]
    [QmfQTbC3LxfpK5WoyHW2WgnAzo6d6GePuq2wHTsJNXM5PS] ping QmNXUeFrV9gxR4aqJddEsfhWZLSJrUsfpUSeRb3R7xvSp9 end (err = %!s(<nil>))

cc @whyrusleeping
@jbenet jbenet added the status/in-progress In progress label Sep 23, 2014
@jbenet
Copy link
Member Author

jbenet commented Sep 23, 2014

This fixes the broken pinging. (the issue was the cluster level, it was being set incorrectly (off by one))

Anyway, this works now:

[peer: QmfQTbC3LxfpK5WoyHW2WgnAzo6d6GePuq2wHTsJNXM5PS] Sent message type: 'PING' [to = QmNXUeFrV9gxR4aqJddEsfhWZLSJrUsfpUSeRb3R7xvSp9]
[QmfQTbC3LxfpK5WoyHW2WgnAzo6d6GePuq2wHTsJNXM5PS] ping QmNXUeFrV9gxR4aqJddEsfhWZLSJrUsfpUSeRb3R7xvSp9 end (err = %!s(<nil>))

cc @whyrusleeping

@whyrusleeping
Copy link
Member

Looks good to me!

@btc
Copy link
Contributor

btc commented Sep 23, 2014

LGTM

btc pushed a commit that referenced this pull request Sep 23, 2014
@btc btc merged commit f001975 into master Sep 23, 2014
@btc btc deleted the feat/fix-ping branch September 23, 2014 20:20
@btc btc removed the status/in-progress In progress label Sep 23, 2014
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants