Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin ls $cid hits the network for non pinned $cid #7624

Closed
hsanjuan opened this issue Aug 26, 2020 · 1 comment
Closed

pin ls $cid hits the network for non pinned $cid #7624

hsanjuan opened this issue Aug 26, 2020 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@hsanjuan
Copy link
Contributor

Version: master, ipfs 0.6.0

ipfs pin ls --type recursive $cid seems to hit the network for a non pinned CID.

This is quite breaking and a regression from 0.5.0. IPFS Cluster relies on this command to check if something is pinned. When there are no providers for an item, everything will hang.

I will bisec this in a minute.
@hsanjuan hsanjuan added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Aug 26, 2020
@hsanjuan
Copy link
Contributor Author

This was introduced in 6ef190f

aschmahmann added a commit that referenced this issue Aug 26, 2020
@aschmahmann
Merge pull request #7625 from ipfs/fix/7624-do-not-fetch-on-pin-ls
38da1cc 
Fix #7624: Do not fetch dag nodes when checking if a pin exists
@aschmahmann aschmahmann mentioned this issue Sep 22, 2020
Closed
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hsanjuan