Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic on unexpected peer ID #398

Closed
whyrusleeping opened this issue Dec 1, 2014 · 2 comments
Closed

panic on unexpected peer ID #398

whyrusleeping opened this issue Dec 1, 2014 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@whyrusleeping
Copy link
Member

secureConn will panic if the peer you are talking to isnt the peer you expect.

How I encountered this:

Create peer A, connect to mars, add and provide a file.
delete peer A's config directory and re initialize, peer A now becomes C
from a second peer (B) request the file that was initially added by A,
B will now try to connect to 'A' via providers records, but instead connect to C (same ip as original peer A).
handshake assumptions will then fail.

@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label Dec 1, 2014
@whyrusleeping
Copy link
Member Author

Encountered this one a few more times.

@jbenet
Copy link
Member

jbenet commented Jan 8, 2015

lmk if you can repro this-- it tried quickly with new net code and couldn't.

@jbenet jbenet closed this as completed Jan 8, 2015
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants