Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test interoperability with Helia and remove dependency on ipfs/interop #10013

Closed
BigLep opened this issue Jul 6, 2023 · 1 comment · Fixed by #10042
Closed

Test interoperability with Helia and remove dependency on ipfs/interop #10013

BigLep opened this issue Jul 6, 2023 · 1 comment · Fixed by #10042

Comments

@BigLep
Copy link
Contributor

BigLep commented Jul 6, 2023

Done Criteria

  1. Kubo no longer relies on https://github.com/ipfs/interop for interoperability testing
  2. Kubo CI checks to ensure it doesn't break compatibility with Helia
  3. https://github.com/ipfs/interop is archived

Why Important

We don't have Helia interoperability testing.
Relying on js-ipfs testing is keeping things like mplex around even though it should be deprecated: #9958

Notes

https://github.com/ipfs/interop is testing js-ipfs/js-ipfs, js-ipfs/kubo, and kubo/kubo.
js-ipfs is deprecated: ipfs/js-ipfs#4336
We're not covering Kubo/Helia in the Kubo CI.
Kubo tests cover the Kubo/Kubo case better.

Ideally, we run https://github.com/ipfs/helia/tree/main/packages/interop as part of Kubo CI and configure it to test the latest blessed Helia release against any PR's against Kubo master/main.
@Jorropo
Copy link
Contributor

Jorropo commented Jul 6, 2023

👍 thx, we should also archive ipfs/interop

@BigLep BigLep mentioned this issue Jul 6, 2023
Closed
6 tasks
@Jorropo Jorropo mentioned this issue Aug 1, 2023
Merged
achingbrain added a commit to ipfs/npm-kubo that referenced this issue Aug 1, 2023
@Jorropo @achingbrain
feat: add KUBO_BINARY env to allow overriding the path used (#62)
4441b8a 
Refs: ipfs/kubo#10013

---------

Co-authored-by: Alex Potsides <alex@achingbrain.net>
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
2447510 
Fixes #10013
@Jorropo Jorropo mentioned this issue Aug 1, 2023
Merged
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
5415496 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
021df28 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
da788e7 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
7a5f633 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
e361a97 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
96d9e3d 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
9b7121e 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
d51a5eb 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
a5d123d 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
63390f7 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
f413ad8 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 1, 2023
@Jorropo
ci: switch interop tests from js-ipfs to helia
62463fc 
Fixes #10013
Jorropo added a commit that referenced this issue Aug 2, 2023
@Jorropo @hacdias
ci: switch from testing against js-ipfs to helia (#10042)
5bec4d6 
* ci: switch interop tests from js-ipfs to helia

Fixes #10013

* Update .github/workflows/build.yml

Co-authored-by: Henrique Dias <hacdias@gmail.com>

---------

Co-authored-by: Henrique Dias <hacdias@gmail.com>
@BigLep BigLep mentioned this issue Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: switch from testing against js-ipfs to helia ipfs/kubo
2 participants
@BigLep @Jorropo