Fix linter problems on master.

ipfs · May 4, 2022 · 4dd1a24 · 4dd1a24
1 parent cab6927
commit 4dd1a24
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/commands/reqlog.go b/commands/reqlog.go
@@ -42,7 +42,7 @@ func (rl *ReqLog) AddEntry(rle *ReqLogEntry) {
 	rl.nextID++
 	rl.Requests = append(rl.Requests, rle)
 
-	if rle == nil || !rle.Active {
+	if !rle.Active {
 		rl.maybeCleanup()
 	}
 }

diff --git a/core/commands/version.go b/core/commands/version.go
@@ -71,7 +71,7 @@ var VersionCmd = &cmds.Command{
 				return nil
 			}
 
-			fmt.Fprint(w, fmt.Sprintf("ipfs version %s%s\n", version.Version, commitTxt))
+			fmt.Fprintf(w, "ipfs version %s%s\n", version.Version, commitTxt)
 			return nil
 		}),
 	},

diff --git a/core/coreapi/name.go b/core/coreapi/name.go
@@ -75,6 +75,7 @@ func (api *NameAPI) Publish(ctx context.Context, p path.Path, opts ...caopts.Nam
 	}
 
 	if options.TTL != nil {
+		// nolint: staticcheck // non-backward compatible change
 		ctx = context.WithValue(ctx, "ipns-publish-ttl", *options.TTL)
 	}
 

diff --git a/core/corehttp/hostname.go b/core/corehttp/hostname.go
@@ -249,6 +249,7 @@ func withHostnameContext(r *http.Request, hostname string) *http.Request {
 	// on subdomain and dnslink gateways. While DNSlink could read value from
 	// Host header, subdomain gateways have more comples rules (knownSubdomainDetails)
 	// More: https://github.com/ipfs/dir-index-html/issues/42
+	// nolint: staticcheck // non-backward compatible change
 	ctx := context.WithValue(r.Context(), "gw-hostname", hostname)
 	return r.WithContext(ctx)
 }