This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
Migration 8 #4
Merged
Migration 8 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2019
Merged
9 tasks
AuHau
force-pushed
the
migration/8-multihash_and_keys
branch
from
412a11d
to
c43e20b
Compare
alanshaw
suggested changes
Nov 11, 2019
| const store = await maybeWithSharding(baseStore, storageOptions) | ||
|
|
||
| try { | ||
| const batch = store.batch() |
There was a problem hiding this comment.
We can't buffer the entire contents of a repo into memory. This has to be done incrementally.
|
Tbh I like having the Regarding the |
|
Tests are failing in the browser due to ipfs/js-stores#198 |
|
Not any more - we've switched back to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.