Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: replace @tableflip/react-inspector with react-inspector #407

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Nov 29, 2023

This puts a large dent in ipfs/ipfs-webui#1965 thanks to removing this very old library.

@SgtPooki SgtPooki requested a review from a team as a code owner November 29, 2023 01:49
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@@ -129,7 +129,6 @@
"@libp2p/delegated-peer-routing": "^4.0.6",
"@libp2p/ipni-content-routing": "^1.0.1",
"@loadable/component": "^5.14.1",
"@tableflip/react-inspector": "^2.3.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasn't been updated in >5years.

@@ -141,6 +140,7 @@
"libp2p": "^0.45.1",
"milliseconds": "^1.0.3",
"multiformats": "^11.0.2",
"react-inspector": "^6.0.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated 6 months ago. supports react 18

import filesize from 'filesize'
import { CID } from 'multiformats'
import React from 'react'
import { withTranslation } from 'react-i18next'
import { ObjectInspector, chromeLight } from 'react-inspector'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be a straight replacement with no issues testing locally.

@SgtPooki SgtPooki enabled auto-merge (squash) November 29, 2023 21:33
@SgtPooki SgtPooki changed the title chore: replace @tableflip/react-inspector with react-inspector deps: replace @tableflip/react-inspector with react-inspector Nov 29, 2023
@SgtPooki SgtPooki merged commit 754c2ac into master Nov 29, 2023
16 checks passed
@SgtPooki SgtPooki deleted the chore/replace-react-inspector branch November 29, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant