fix(file-preview): safeSubresourceGwUrl #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this aims to sanitize localhost src url for embedded image/audio/video to avoid mixed-content warning in latest chrome-based browsers Rationale: #2246 (comment)
lidel
force-pushed
the
fix/cross-origin-localhost-mixed-content
branch
from
8fdc528
to
1a56429
Compare
lidel
commented
Aug 30, 2024
There was a problem hiding this comment.
The challenge of testing this, is that it works on localhost subdomain, but it may be a bug in chrome that manifests only when top level document URL is https:// and not just a secure context (in Chromium codebase, these are not the same, and we reported bugs before).
I'm going to merge this and deploy to dev.webui.ipfs.io:
- If problem is solved, we will cut a patch release next week.
- If not, I'll fill a bug in Chromium issue tracker and as Igalia for help.
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to sanitize localhost
srcurl for embedded image/audio/video to avoid mixed-content warning in latest chrome-based browsers.Rationale: #2246 (comment)