fix: selection for text files #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1809 by changing the drag layer to the inside of
PreviewItem(renamedPreview). Now the dragging only applies to images, videos, audio and PDFs.With this, I also removed the part of the class
className={ classNames(type !== 'pdf' && type !== 'text' && type !== 'json' && 'dib') }. It didn't seem to change anything in practical terms. /cc @rafaelramalho19 any reason why was that added?License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com