fix: download directories outside of MFS #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
requested review from
rafaelramalho19
and removed request for
rafaelramalho19
rafaelramalho19
approved these changes
Aug 16, 2021
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1829.
I went with a simpler approach than #1814 (comment) (suggested fix) because the API is POST-only, so creating a link and then "opening" it would have returned a 405 error.
When ipfs/kubo#8234 is merged, #1814 can be addressed. In the meanwhile, #1829 is easily fixed.
The failing tests are the same as in the main branch.
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com