fix(ci): update on new go ipfs automation #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `sh` provided by CI uses different shell than bash, so '<<<' used in /entrypoint.sh:35 did not work - this should fix it
dependabot was updating dependency, which means out automation from .github/workflows/update-on-new-ipfs-tag.yml would not run. this disables dependabot for tools/http-api-docs/go.mod, making sure our generator does not get broken silently
one-time fix these updates were missed sue to bugs fixed by previous two commits
|
laurentsenta
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix automation that runs on new go-ipfs release:
The
shprovided by CI uses a different shell than bash, so<<<used below did not work (CI failure - this should fix it.ipfs-docs/.github/actions/update-on-new-ipfs-tag/entrypoint.sh
Line 35 in b7aef5c
Dependabot was updating go-ipfs dependency in
tools/http-api-docs/go.mod(example: chore(deps): bump github.com/ipfs/go-ipfs from 0.12.0 to 0.12.1 in /tools/http-api-docs #1109), which means our automation from.github/workflows/update-on-new-ipfs-tag.ymlthought we already have all versions up to date and did not run for 0.12.1 and 0.12.2 🙈This PR disables dependabot for
tools/http-api-docs/go.moddeps, making sure our generator does not get broken silentlyone-time fix to get us up-to-speed
(already fixed HTTP RPC docs in feat: document deprecated RPC API commands #1086, these are remaining updates were missed because of bugs fixed above)