refactor: remove dir-index-html submodule #8555
Conversation
First part of the fix to ipfs/dir-index-html#3
adds url escaping of entries
Standardize README
Add "jpeg" as an alias to "jpg".
This template will only get passed the hash value if the hash is not already being shown in the path. If a hash value is passed in, it will display under the path in grey. License: MIT Singed-off-by: Jack Loughran <j@ckloughran.com>
…-hash show hash if given
…con" This reverts commit b976e3c.
This reverts commit 6895e1c.
This reverts commit 6681721.
…ks and bug report icon, misc styling
Updates header, adds links
This adds GithubAction that runs the build and checks for any unstaged changes. This ensures `src/dir-index.html` match the output `dir-index.html` in the main directory.
feat: Build script
- Links to direct CIDs now have ?filename= param to preserve name and content type - When page is loaded on DNSLink website (based on Host header) then there is no public gateway endpoint. As a replacement, clicking on a CID opens it at cid.ipfs.io Context: ipfs/dir-index-html#42 Closes ipfs#42
for some reason `-e` gets interpreted literally at CI. This removes its use making the output look the same everywhere. CI will now show diff if uncommited changes to make it easier to see what caused CI to fail.
feat: improved CID column (filename and dnslink support)
Bump version in package.json
* fix: disable translation of cids * fix: explicit language of the document
This comment has been minimized.
This comment has been minimized.
|
Hi, @lidel I have successfully done the step of removing submodule into go-ipfs, and also keeping the commit history of |
lidel
changed the title
There was a problem hiding this comment.
Thank you for cleaning up this @longfeiWan9! ❤️
go generate .seems to work fine for me locally and on CI – ask around, could be macOS thing- I restarted CI and tests look good now
- changes look good to me, but before we merge this, we need to clean up some things that are no longer needed. See comments inline.
|
@lidel Thanks for all the comments. I have updated the code accordingly, could you please take a look at it to see I understand you and fix it correctly? |
There was a problem hiding this comment.
Looks good, thank you for cleaning this up @longfeiWan9
@aschmahmann this is ready for merging. Given the license change and related contributor signoffs (or their lack) we may want to preserve original history, but perhaps it is enough to have it on this PR, and only land squashed commit on master? I'm fine either way.
|
Discussed during triage: due to commits reaching way back beyond the license changes, and related contributor signoffs (or their lack) we want to preserve original history and will merge this with merge commit. We most likely want to merge this one as last before the release, just so we can undo if something goes wrong. |
lidel
force-pushed
the
feat/remove-submodule
branch
from
9444a9a
to
302c97f
Compare
This PR will close #8532.
dir-index-htmlsubmodule back togo-ipfsdir-index-htmlbinddatastill works as expected with commandgo generate .go generate .to build./assets/dir-index-html/dir-index.htmlfrom./assets/dir-index-html/src/./assets/dir-index-html/.github|gx